On Wed, Jul 06, 2011 at 10:03:02PM -0600, Erich Hoover wrote: > On Wed, Jul 6, 2011 at 12:15 AM, Peter Hutterer > <[email protected]>wrote: > > > ... > > > I'll have to check and see if there's any difference between the > > ISDV4_QUERY > > > on the models I have available that exhibit this feature (tc1100, tc4200, > > > and tc4400) vs the ones that don't (2710p and 2740p). I'm not sure how > > else > > > one could figure this out. > > > > The PNPID may be the key here to tweak those options. > > > > Is that the sysfs-based id that gets passed to set_keybits_wacom?
correct. you'd have to add a new model to isdv4_models, find the matching regex and then go from there. The current code relies on the model to only contain numbers that can be used as id. If there's more than that involved, some larger changes may be necessary. > ... > > > I doubt there are any other tablets that exhibit these crazy buttons, > > > otherwise people probably would have complained by now. Would it be too > > > much of a problem to include this feature and then up the number of > > buttons > > > if someone finds some overlap? > > > > depends much. If we can't label them, then it may be. Once clients start > > relying on the buttons to be on certain numbers (which they shouldnt, > > but...) then moving them later can cause confusion. > > > > > > ... > > > > > + ds->device_type = STYLUS_ID; > > > > > > > > shouldn't this be PAD_ID? > > > > > > > > > > I'm not familiar with how PAD_ID is supposed to be used. If it helps, > > these > > > are three buttons located on the side of the display that are generally > > > referred to as the "pen buttons" (they must be pushed with the stylus): > > > http://img.muare.vn/haibaxa/HP1100.jpg > > > > hmm. I'd probably still prefer these to be pushed through the pad, leaving > > the stylus with the 3 buttons it usually has. > > > > Would it make sense to put these as the first 3 buttons for the PAD_ID? > That way if there ends up being an overlap with some other device then it > should become obviously very rapidly (ie. before anyone starts to rely on > any particular behavior). I don't think that's a good idea. Anyone who already relies on pad buttons to be just buttons (which is the case on all pads) would be confused if they have special functionality. > ... > > fair enough. Plan sounds good, but please see if the isdv4 parsing code > > complains about out-of-sync packets if you set it to 2. > > > > Looks like the reason there were no complaints is that wcmSkipInvalidBytes > call in isdv4Parse does not report a warning when it skips bytes. I > manually added a warning and found it skipping bytes when I return 2, and > the warning is not generated when I return ISDV4_PKGLEN_TPCPEN (9) bytes > instead. Looks like I'll have to test for the "pen button bit" specifically > rather than play with the length. have you tried running the isdv4-serial-debugger against it? It should show the other data in that packet, so you can check if there's anything of value in there. Cheers, Peter ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
