On Sun, Jul 10, 2011 at 10:17:22AM -0600, Erich Hoover wrote: > On Wed, Jul 6, 2011 at 10:37 PM, Peter Hutterer > <[email protected]>wrote: > > > On Wed, Jul 06, 2011 at 10:03:02PM -0600, Erich Hoover wrote: > > > On Wed, Jul 6, 2011 at 12:15 AM, Peter Hutterer < > > [email protected]>wrote: > > > ... > > > > The PNPID may be the key here to tweak those options. > > > Is that the sysfs-based id that gets passed to set_keybits_wacom? > > correct. you'd have to add a new model to isdv4_models, find the matching > > regex and then go from there. The current code relies on the model to only > > contain numbers that can be used as id. If there's more than that involved, > > some larger changes may be necessary. > > > > I pulled out three of the five models we have and they have the following > ids: > 0x005: HP tc1100 (has pen buttons) > 0x006: HP tc4200 (has pen buttons) > 0x004: HP 2710p (no pen buttons)
What's the full PNPID string? I ask because I think 0x5 and 0x6 are already in use for some wacom tablets. also, before I forget: the kernel w8001 driver supports ISDV4 multi-finger protocol, so your change should go in there as well. long-term, the X11-driver ISDV4 parsing is bound to go away. > I'm assuming/hoping that the tc4400 has the same hardware as the tc4200 and > the 2710p shares hardware with the 2740p. Anyway, it seems that we could > check for ids 0x05 and 0x06 and use SETBIT(keys, BTN_0) for both of these > and then later test for BTN_0 before using pen button packets. In addition, > we could potentially use a different bit (BTN_1?) to indicate the 0x06 type > tablet where the button code is "rotated" (so that the same button numbers > can be generated for tablets of different models). Does this sound > reasonable? On a general basis: rather than trickery with magic bits, I'd be nicer to get a new set of BTN_... defines into the kernel. We can then use that in the driver without having to use hacks. For kernels that don't support it, we can still #define that with the same value. Makes sense? For this particular use-case: there is a KEY_KEYBOARD already which may be suitable here (ask on linux-input) and I wonder if KEY_EDITOR would be suitable for the "writing tool" (whatever that is). There is no rotation button or key yet afaict. > have you tried running the isdv4-serial-debugger against it? It should show > > the other data in that packet, so you can check if there's anything of > > value > > in there. > > > > I used memdump() on the data: the first byte is 0xC1, the second is a > bit-wise button code, and all the remaining bytes are all zero. I guess that's a good enough hint then ;) using the proper packet length as return code would be good though. Cheers, Peter ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
