On Mon, Sep 05, 2011 at 10:22:12AM -0500, Chris Bagwell wrote: > On Sun, Sep 4, 2011 at 11:02 PM, Peter Hutterer > <peter.hutte...@who-t.net> wrote: > > On Sun, Sep 04, 2011 at 10:54:48PM -0500, Chris Bagwell wrote: > >> The reason I'm using the -1 work around is because wcmInitModel() is > >> called after wcmParseOptions(). The *GetRanges function is called > >> during Init phase and so we do not have touch resolution until after > >> we've initialized the touch related options. > > > > then we need to split wcmParseOptions into wcmParseModelOptions() and > > wcmParseOtherOptions() (or something like that). > > > > or just move the xf86Set...Options that cannot be extracted in > > wcmParseOptions() to where they need to be (with a comment explaining why) > > > > Agree. This has been an issue to me multiple times in the past. So I > should create a new flow that lets parse options right after Init > phase for stuff like this.
yeah. in the server we have PreInit and PostInit exactly for stuff that can only be handled afterwards. There's an argument to be made to collate all those that can only be initialized after a certain spot to avoid having xf86SetFoo sprinkled all over the source again but in some cases that may not be viable either and the odd xf86SetFoo elsewhere is necessary. Cheers, Peter ------------------------------------------------------------------------------ Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free "Love Thy Logs" t-shirt when you download Logger. Secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsisghtdev2dev _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
