medismailben wrote: > > Can we break this up into an NFC patch that makes `LineEntry` a class and a > > separate PR for the functional change that makes `AddressRange` optional? > > +1. > > Why do you want to turn it into a class? In C++, the only difference between > a class and a struct is the default access level. Structs are public by > default, Classes are private by default.
To Alex's point, this didn't require to turn the `LineEntry` struct in to a class so I just made the `range` member a private optional and added public getter/setter methods. https://github.com/llvm/llvm-project/pull/158811 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
