https://github.com/JDevlieghere requested changes to this pull request.
I strongly dislike this API because it easy to misuse and hard to use correctly. That's based on my very recent experience with the SupportFileSP. When it's used incorrectly (which it will, just like SupportFileSP was) it will lead to subtle and hard to diagnose bugs. My main qualm is the `GetRange` accessor which gives a false sense of security. If we need to make the `AddressRange` optional, then we should just keep it a (public) member and force every call site to consider that it may not be present. https://github.com/llvm/llvm-project/pull/158811 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
