https://github.com/bulbazord requested changes to this pull request.
Instead of modifying the AddressRange member to be an optional, why not *only* relax the `LineEntry` validity check? There's a lot of code that needs to be changed here to make the `range` member optional and you need to remember to call `HasValidRange`. Not every place that accesses the AddressRange checks for a valid range either. Functionally, the only benefit to having AddressRange be an optional is you can tell the difference between "The AddressRange was set to an invalid value" versus "The AddressRange member was untouched". Is there value in knowing the difference? Requesting changes because my current impression is that this adds unnecessary complexity to LineEntry. https://github.com/llvm/llvm-project/pull/158811 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
