https://github.com/JDevlieghere requested changes to this pull request.
Can you please update the PR description with more details about why this is necessary? The current description doesn't explain the problem this is solving nor how this is the (best) solution. In the context of the line table it makes sense to require a line entry to have an address (range). This PR also needs to motivate why dropping this requirement makes sense. Finally, we have a bunch of places across LLDB that call `IsValid`. I see it referenced in `SymbolContext`, `StackFrame`, `Disassembler`, `FormatEntity`, `CommandObjectSource`. Did you look through all its uses and confirmed that this change in behavior remains correct? I'm not saying this isn't the right approach, but right now there's not enough information in this PR to come to the conclusion that it is. https://github.com/llvm/llvm-project/pull/158811 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
