mgorny added inline comments.
================
Comment at: lldb/source/Symbol/SymbolContext.cpp:986
- m_end_line = StringConvert::ToSInt32(spec_string, 0, 0, &return_value);
- if (return_value)
m_type |= eLineEndSpecified;
----------------
teemperor wrote:
> This change and the one above make this return true on a parse failure. LLDB
> is of course one step ahead of us here and never even checks the return value
> anywhere (...), but I think it still makes sense to preserve the behaviour in
> this patch.
Ahh, good catch. Will fix in a minute.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110447/new/
https://reviews.llvm.org/D110447
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
