arsenm wrote:

> This seems like an excessive number of tests. I think the cross product of 
> ever supported type and every supported setp isn't really necessary. Can you 
> please cut this down to a more manageable number? Otherwise LGTM

I think these sorts of things should be comprehensive for every opcode. However 
they don't really need to have all of these separate test files 

https://github.com/llvm/llvm-project/pull/191890
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to