On 2015-04-29 14:43, Mike Holmes wrote: > On 29 April 2015 at 12:25, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > > > Merged. > > > > Discussed with Mike on his comment that there is no API change it's define > > value change, i.e. implementation. > > > > To clarify, we discussed if this is an API change and should come via > api-next. > > My initial point was that it touched odp/include so it must go via api-next > simply for that reason. The counter point was that the defines name did not > change so it was the implementation that change i.e. just the number.
Disagree. > > But this is in the public API so it may be used in an application and it > could now change the size of a structure in memory. Agree. > > So this patch is a test case to clarify what we mean by an API change, so > that we can document it. I still feel that it is simplest to say any change > to odp/include goes via api-next. I think this makes sense. > > NOTE: With this merged 1.0.4 will contain this change to odp/include This is an API change on a 32bit system and the patch must be reverted. Cheers, Anders > > > > > > > While api: patch prefix is good here to indicate that api file was touched. > > > > Thank you, > > Maxim. > > > > > > > > On 04/28/2015 14:44, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > > >> OK. It avoids casting on application side. > >> > >> Reviewed-by: Petri Savolainen <petri.savolai...@nokia.com> > >> > >> > >> > >> -----Original Message----- > >>> From: ext Maxim Uvarov [mailto:maxim.uva...@linaro.org] > >>> Sent: Tuesday, April 28, 2015 2:13 PM > >>> To: lng-odp@lists.linaro.org; Petri Savolainen; Robbie King (robking) > >>> Subject: Re: [lng-odp] [PATCH] api: time: force time defines as ULL to > >>> avoid computation overflows on 32bits systems > >>> > >>> Looks good. Perti, Robbie ok? > >>> > >>> Maxim. > >>> > >>> On 04/24/2015 16:09, Nicolas Morey-Chaisemartin wrote: > >>> > >>>> For example the odp_timer validation tests computes 10 * ODP_TIME_SEC > >>>> > >>> and stores it into an uint64_t, but the computation overflows on 32b > >>> systems and the test fails > >>> > >>>> Signed-off-by: Nicolas Morey-Chaisemartin <nmo...@kalray.eu> > >>>> --- > >>>> include/odp/api/time.h | 6 +++--- > >>>> 1 file changed, 3 insertions(+), 3 deletions(-) > >>>> > >>>> diff --git a/include/odp/api/time.h b/include/odp/api/time.h > >>>> index 6b811d0..836866d 100644 > >>>> --- a/include/odp/api/time.h > >>>> +++ b/include/odp/api/time.h > >>>> @@ -24,9 +24,9 @@ extern "C" { > >>>> */ > >>>> > >>>> /* Time in nanoseconds */ > >>>> -#define ODP_TIME_USEC 1000UL /**< Microsecond in nsec */ > >>>> -#define ODP_TIME_MSEC 1000000UL /**< Millisecond in nsec */ > >>>> -#define ODP_TIME_SEC 1000000000UL /**< Second in nsec */ > >>>> +#define ODP_TIME_USEC 1000ULL /**< Microsecond in nsec */ > >>>> +#define ODP_TIME_MSEC 1000000ULL /**< Millisecond in nsec */ > >>>> +#define ODP_TIME_SEC 1000000000ULL /**< Second in nsec */ > >>>> > >>>> > >>>> /** > >>>> _______________________________________________ > >>>> lng-odp mailing list > >>>> lng-odp@lists.linaro.org > >>>> https://lists.linaro.org/mailman/listinfo/lng-odp > >>>> > >>> > > _______________________________________________ > > lng-odp mailing list > > lng-odp@lists.linaro.org > > https://lists.linaro.org/mailman/listinfo/lng-odp > > > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp -- Anders Roxell anders.rox...@linaro.org M: +46 709 71 42 85 | IRC: roxell _______________________________________________ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
