On 29/09/2008 10:53, Jean-Marc Lasgouttes wrote:
[EMAIL PROTECTED] writes:
Fix bug http://bugzilla.lyx.org/show_bug.cgi?id=5285 .
--- lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp (original)
+++ lyx-devel/trunk/src/frontends/qt4/GuiParagraph.cpp Fri Sep 26 23:34:08 2008
@@ -338,6 +338,7 @@
bufferview()->updateMetrics();
bufferview()->buffer().changed();
+ bufferview()->buffer().markDirty();
}
OK, after having a look at the code, I have some answer.
This is typically a consequence of code that tries to be smart: directly
access param at point when we do not have a selection, and avoid to
dispatch an lfun.
That is not a question of smartness but of efficiency. At the time I
didn't want to trigger to make a full copy of the current parameter set
each cursor move. That was not to avoid the dispatch of an LFUN which
can still be done easily with current code.
So, when we have several paragraphs, the dirty flag is correctly set,
but when there is only one, nothing correct happens.
That's an incorrect comment.
I really do not
understand why it can be needed to separate these two cases (it
corresponds to more code, AFAIK).
See above.
I think this chage should be reverted and GuiParagraph should be changed
to work through LyXFunc.
I'll do that.
Abdel.
