On 3/20/19 5:14 PM, Jean-Marc Lasgouttes wrote: > Le 20/03/2019 à 11:58, Jean-Marc Lasgouttes a écrit : >> Le 20/03/2019 à 11:46, Jean-Marc Lasgouttes a écrit : >>> commit d3979e798cd9c85041bb5e6158002384a8cddb8c >>> Author: Jean-Marc Lasgouttes <[email protected]> >>> Date: Wed Mar 20 10:56:16 2019 +0100 >>> >>> Cache the value of GuiFontMetrics::lbearing(). >>> This seems to be necessary on windows, where math editing can >>> get very >>> slow. Note that other methods like rbearing already use a cache. >>> In the future all these caches for single characters shall be >>> unified. >> >> This should alleviate the performance issues on windows. I will see >> tonight on my windows machine how effective it is. At least it is >> much less intrusive than trying to reduce the amount of painting. >> >> If it makes LyX on windows faster, this will be candidate for 2.3.3. > > I can confirm this this helps a lot on windows, at least with the test > case that we received. > > Riki, OK to backport?
Yes, thank you. Is there any danger to this, do you think? If so, I could try to produce a 'testing' binary before we move toward the real release. Riki
