Jean-Marc Lasgouttes wrote: > Note that, among your fixes, I skipped the one that did not seem > obvious to port or which did not feel 100% safe. The ones I am aware > of are: > > * http://www.lyx.org/trac/changeset/14470 > http://www.lyx.org/trac/changeset/14529 > What was the result of your discusson with Andre'? Is the patch well > tested?
The result is that he did not answer to my last post, so I put my solution in. The patch is well tested and safe IMO. > * http://www.lyx.org/trac/changeset/14474 > > The code in 1.4 is very different. I'd rather let you port it. I'll do that. > * http://www.lyx.org/trac/changeset/14481 > > As I commented in bug 2687, I am not sure it is the best solution. > > - either we do what you did and quoteArg should be changed to some > LyXLex static function (as it would be used also for quoting > viewer names in preferences, for example). I prefer that. > - or we decide that everything up to the end of the string is the > second arg, like file-open does, I think. I don't like this, because the quoting solution makes more clear what exactly the filename is. The difference to file-open is that we can't take the whole argument, we have to split off the dialog name first. > What else? I don't know, but a bugzilla search for fixedintrunk bugs would show if anything is missing, because I always added that keyword. Georg
