Kipcool has submitted this change and it was merged.
Change subject: Tags
......................................................................
Tags
removed comments and set expiry to 24 hours.
also made the code more compact.
Change-Id: I4f8e7d56f7d70bb44075bca7e044493d4d475a3d
---
M includes/OmegaWikiTags.php
1 file changed, 12 insertions(+), 40 deletions(-)
Approvals:
Kipcool: Verified; Looks good to me, approved
diff --git a/includes/OmegaWikiTags.php b/includes/OmegaWikiTags.php
index 9542f46..679baf9 100644
--- a/includes/OmegaWikiTags.php
+++ b/includes/OmegaWikiTags.php
@@ -22,71 +22,43 @@
function owExpStats( $input ) {
$cache = new CacheHelper();
- $number = $cache->setCacheKey( array( 'ow_stats_exp' ) );
+ $cache->setCacheKey( array( 'ow_stats_exp' ) );
$number = $cache->getCachedValue( function () {
$Expressions = new Expressions;
- $number = $Expressions->getNumberOfExpressions();
-
- // This line is for checking. Delete if certified ok!
- echo "cached value for ow_stats_exp not found.<br/>";
-
- return $number;
+ return $Expressions->getNumberOfExpressions();
} );
-
- // line set to 35 seconds for testing, please set to 86400.
- $cache->setExpiry( 35 );
-
+ $cache->setExpiry( 86400 );
$cache->saveCache();
- $number = "$number ";
- $number = preg_replace( '/\D $/', '', $number );
+ $number = preg_replace( '/\D $/', '', "$number " );
return htmlspecialchars( $number . $input );
}
function owDefinedMeaningStats( $input ) {
$cache = new CacheHelper();
- $number = $cache->setCacheKey( array( 'ow_stats_dm' ) );
+ $cache->setCacheKey( array( 'ow_stats_dm' ) );
$number = $cache->getCachedValue( function () {
- $number = getNumberOfDefinedMeanings();
-
- // This line is for checking. Delete if certified ok!
- echo "cached value for ow_stats_dm not found.<br/>";
-
- return $number;
+ return getNumberOfDefinedMeanings();
} );
-
- // line set to 35 seconds for testing, please set to 86400.
- $cache->setExpiry( 35 );
-
+ $cache->setExpiry( 86400 );
$cache->saveCache();
- $number = "$number ";
- $number = preg_replace( '/\D $/', '', $number );
+ $number = preg_replace( '/\D $/', '', "$number " );
return htmlspecialchars( $number . $input );
}
function wldLanguageStats( $input ) {
$cache = new CacheHelper();
- $number = $cache->setCacheKey( array( 'wld_stats_lang' ) );
+ $cache->setCacheKey( array( 'wld_stats_lang' ) );
$number = $cache->getCachedValue( function () {
- $number = getNumberOfLanguages();
-
- // This line is for checking. Delete if certified ok!
- echo "cached value for wld_stats_lang not found.<br/>";
-
- return $number;
+ return getNumberOfLanguages();
} );
-
-
- // line set to 35 seconds for testing, please set to 86400.
- $cache->setExpiry( 35 );
-
+ $cache->setExpiry( 86400 );
$cache->saveCache();
- $number = "$number ";
- $number = preg_replace( '/\D $/', '', $number );
+ $number = preg_replace( '/\D $/', '', "$number " );
return htmlspecialchars( $number . $input );
}
--
To view, visit https://gerrit.wikimedia.org/r/97692
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f8e7d56f7d70bb44075bca7e044493d4d475a3d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiLexicalData
Gerrit-Branch: master
Gerrit-Owner: Hiong3-eng5 <hiong3.e...@gmail.com>
Gerrit-Reviewer: Kipcool <kipmas...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
