IAlex has uploaded a new change for review.
https://gerrit.wikimedia.org/r/101651
Change subject: Don't pass $this by reference to SkinVectorStyleModules hook.
......................................................................
Don't pass $this by reference to SkinVectorStyleModules hook.
Fix for Ica0b69ad95 (8b6ed4d0).
$this cannot be changed, so there is not any reason to pass
it by reference.
Change-Id: I916ccabbaff9f60edb344550111f62c833bb137b
---
M skins/Vector.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/51/101651/1
diff --git a/skins/Vector.php b/skins/Vector.php
index 288b5fd..158700f 100644
--- a/skins/Vector.php
+++ b/skins/Vector.php
@@ -68,7 +68,7 @@
parent::setupSkinUserCss( $out );
$styles = array( 'skins.vector' );
- wfRunHooks( 'SkinVectorStyleModules', array( &$this, &$styles )
);
+ wfRunHooks( 'SkinVectorStyleModules', array( $this, &$styles )
);
$out->addModuleStyles( $styles );
}
--
To view, visit https://gerrit.wikimedia.org/r/101651
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I916ccabbaff9f60edb344550111f62c833bb137b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: IAlex <coderev...@emsenhuber.ch>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
