jenkins-bot has submitted this change and it was merged.
Change subject: Improve redis connection error log
......................................................................
Improve redis connection error log
Include the server name in the log entry for exceptions thrown during
connect. We are logging a lot of these.
Change-Id: Ia3f775a9e22447efb067c3203a3b80c4385aa2c0
---
M includes/clientpool/RedisConnectionPool.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
IAlex: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/clientpool/RedisConnectionPool.php
b/includes/clientpool/RedisConnectionPool.php
index 537deac..8a6718f 100644
--- a/includes/clientpool/RedisConnectionPool.php
+++ b/includes/clientpool/RedisConnectionPool.php
@@ -210,7 +210,7 @@
}
} catch ( RedisException $e ) {
$this->downServers[$server] = time() +
self::SERVER_DOWN_TTL;
- wfDebugLog( 'redis', "Redis exception: " .
$e->getMessage() . "\n" );
+ wfDebugLog( 'redis', "Redis exception connecting to
$server: " . $e->getMessage() . "\n" );
return false;
}
--
To view, visit https://gerrit.wikimedia.org/r/95579
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3f775a9e22447efb067c3203a3b80c4385aa2c0
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Tim Starling <tstarl...@wikimedia.org>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: IAlex <coderev...@emsenhuber.ch>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
