MaxSem has uploaded a new change for review.
https://gerrit.wikimedia.org/r/141102
Change subject: Fix stopMobileRedirect cookie being set twice with different
prefixes
......................................................................
Fix stopMobileRedirect cookie being set twice with different prefixes
This commit is just a beginning, this whole thing requires much more work.
Bug: 66888
Change-Id: Iceceec749517f637919c7cf2d121ae024fe1cd80
---
M includes/MobileContext.php
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/02/141102/1
diff --git a/includes/MobileContext.php b/includes/MobileContext.php
index df81d57..e01e4db 100644
--- a/includes/MobileContext.php
+++ b/includes/MobileContext.php
@@ -491,6 +491,15 @@
$this->getRequest()->response()->setcookie(
'stopMobileRedirect', 'true', $expiry,
array(
'domain' =>
$this->getStopMobileRedirectCookieDomain(),
+ 'prefix' => '',
+ )
+ );
+ // Bug 66888: cookies were set with current wiki's prefix
instead of an empty prefix.
+ // Delete them.
+ // @todo: Remove this 30 days after deploying
+ $this->getRequest()->response()->setcookie(
'stopMobileRedirect', '', -3600,
+ array(
+ 'domain' =>
$this->getStopMobileRedirectCookieDomain(),
)
);
}
--
To view, visit https://gerrit.wikimedia.org/r/141102
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iceceec749517f637919c7cf2d121ae024fe1cd80
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: MaxSem <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
