jenkins-bot has submitted this change and it was merged.
Change subject: JS and CSS clean up based on static code analysis
......................................................................
JS and CSS clean up based on static code analysis
Thanks to PHPStorm. I actually found a few bugs, but most stuff is
just unused parameters and such.
Change-Id: Ie6e9fc6dc8e0b63d47b3695ec75dcd68f065e06d
---
M client/resources/wikibase.client.getMwApiForRepo.js
M client/resources/wikibase.client.linkitem.init.js
M lib/resources/jquery.wikibase/jquery.wikibase.badgeselector.js
M lib/resources/jquery.wikibase/jquery.wikibase.claimgrouplabelscroll.js
M lib/resources/jquery.wikibase/jquery.wikibase.referenceview.js
M lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
M
lib/resources/jquery.wikibase/themes/default/jquery.wikibase.statementview.RankSelector.css
M lib/resources/wikibase.RepoApi/wikibase.RepoApi.js
M lib/resources/wikibase.sites.js
M lib/resources/wikibase.utilities/wikibase.utilities.ui.js
10 files changed, 20 insertions(+), 19 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
jenkins-bot: Verified
diff --git a/client/resources/wikibase.client.getMwApiForRepo.js
b/client/resources/wikibase.client.getMwApiForRepo.js
index e8238c4..6b5b9e0 100644
--- a/client/resources/wikibase.client.getMwApiForRepo.js
+++ b/client/resources/wikibase.client.getMwApiForRepo.js
@@ -12,8 +12,8 @@
*/
MODULE.getMwApiForRepo = function() {
var repoConfig = mw.config.get( 'wbRepo' ),
- repoApiEndpoint = repoConfig.url +
repoConfig.scriptPath + '/api.php',
- mwApiForRepo = wikibase.api.getLocationAgnosticMwApi(
repoApiEndpoint );
- return mwApiForRepo;
+ repoApiEndpoint = repoConfig.url +
repoConfig.scriptPath + '/api.php';
+
+ return wikibase.api.getLocationAgnosticMwApi( repoApiEndpoint );
};
}( mediaWiki, wikibase ) );
diff --git a/client/resources/wikibase.client.linkitem.init.js
b/client/resources/wikibase.client.linkitem.init.js
index a99922f..e24ef4b 100644
--- a/client/resources/wikibase.client.linkitem.init.js
+++ b/client/resources/wikibase.client.linkitem.init.js
@@ -21,7 +21,7 @@
'jquery.wikibase.linkitem',
'mediawiki.Title',
'mw.config.values.wbRepo',
- 'wikibase.client.getMwApiForRepo',
+ 'wikibase.client.getMwApiForRepo'
],
function() {
$spinner.remove();
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.badgeselector.js
b/lib/resources/jquery.wikibase/jquery.wikibase.badgeselector.js
index 31db028..2bf9675 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.badgeselector.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.badgeselector.js
@@ -352,7 +352,7 @@
* (De-)Activates a badge.
*
* @param {string} badgeId
- * @param {bool} targetState
+ * @param {boolean} targetState
*/
_toggleBadge: function( badgeId, targetState ) {
if( targetState ) {
diff --git
a/lib/resources/jquery.wikibase/jquery.wikibase.claimgrouplabelscroll.js
b/lib/resources/jquery.wikibase/jquery.wikibase.claimgrouplabelscroll.js
index 39f5697..22b7e91 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.claimgrouplabelscroll.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.claimgrouplabelscroll.js
@@ -243,7 +243,7 @@
*
* @param {jQuery} $element
* @param {jQuery} $target
- * @return {false|string} false if the position requires no update,
otherwise the string of
+ * @return {boolean|string} false if the position requires no update,
otherwise the string of
* the "top" css style after the animation will be complete.
*/
function positionElementInOneLineWithAnother( $element, $target ) {
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.referenceview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.referenceview.js
index 2457bd9..ea4b240 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.referenceview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.referenceview.js
@@ -273,7 +273,7 @@
this.element.removeClassByRegex( /wb-reference-.+/ );
this.element.addClass( 'wb-reference-' + refHash );
- this.element.removeClassByRegex( new RegExp(
this.widgetBaseClass ) + '-.+' );
+ this.element.removeClassByRegex( new RegExp(
this.widgetBaseClass + '-.+' ) );
this.element.addClass( this.widgetBaseClass + '-' + refHash );
},
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
index 609d2db..62590dd 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
@@ -353,8 +353,7 @@
return repoApi.removeReferences(
guid,
reference.getHash(),
- wb.getRevisionStore().getClaimRevision( guid ),
- this.option( 'index' )
+ wb.getRevisionStore().getClaimRevision( guid )
).done( function( result ) {
var baseRevId = result.pageinfo;
// update revision store
diff --git
a/lib/resources/jquery.wikibase/themes/default/jquery.wikibase.statementview.RankSelector.css
b/lib/resources/jquery.wikibase/themes/default/jquery.wikibase.statementview.RankSelector.css
index e8c7834..47b98fb 100644
---
a/lib/resources/jquery.wikibase/themes/default/jquery.wikibase.statementview.RankSelector.css
+++
b/lib/resources/jquery.wikibase/themes/default/jquery.wikibase.statementview.RankSelector.css
@@ -15,7 +15,7 @@
}
.wb-rankselector .ui-icon.wb-rankselector-preferred {
- background-position: 0px;
+ background-position: 0;
}
.wb-rankselector .ui-icon.wb-rankselector-normal {
diff --git a/lib/resources/wikibase.RepoApi/wikibase.RepoApi.js
b/lib/resources/wikibase.RepoApi/wikibase.RepoApi.js
index d02b4d4..f501b31 100644
--- a/lib/resources/wikibase.RepoApi/wikibase.RepoApi.js
+++ b/lib/resources/wikibase.RepoApi/wikibase.RepoApi.js
@@ -135,7 +135,7 @@
* default: null (unsorted)
* @param {String} [dir] Sort direction may be 'ascending' or
'descending'
* default: null (ascending)
- * @param {bool} [normalize] Whether to normalize titles
server side
+ * @param {boolean} [normalize] Whether to normalize titles server side
* @return {jQuery.Promise}
*/
getEntitiesByPage: function( sites, titles, props, languages, sort,
dir, normalize ) {
@@ -311,12 +311,14 @@
* Removes an existing claim.
*
* @param {String} claimGuid The GUID of the Claim to be removed
(wb.datamodel.Claim.getGuid)
+ * @param {Number} [claimRevisionId]
* @return {jQuery.Promise}
*/
- removeClaim: function( claimGuid ) {
+ removeClaim: function( claimGuid, claimRevisionId ) {
return this.post( {
action: 'wbremoveclaims',
- claim: claimGuid
+ claim: claimGuid,
+ baserevid: claimRevisionId
} );
},
@@ -440,7 +442,7 @@
* @param {Number} baseRevId revision id
* @param {String} site the site of the link
* @param {String} title the title to link to
- * @param {String[]|String} badges the list of badges
+ * @param {String[]|String} [badges] the list of badges
* @return {jQuery.Promise}
*/
setSitelink: function( id, baseRevId, site, title, badges ) {
@@ -492,7 +494,7 @@
*
* @since 0.4
*
- * @param {Mixed} value
+ * @param {string[]|string} [value]
* @return {string|undefined}
*/
_normalizeParam: function( value ) {
diff --git a/lib/resources/wikibase.sites.js b/lib/resources/wikibase.sites.js
index 2aefcb5..19ac891 100644
--- a/lib/resources/wikibase.sites.js
+++ b/lib/resources/wikibase.sites.js
@@ -15,7 +15,7 @@
*
* TODO: This should go together with the old UI.
*
- * @var wikibase.Site[]
+ * @var Object
*/
this._siteList = null;
@@ -89,7 +89,7 @@
/**
* Returns whether the Wikibase installation knows a site with
a certain ID.
*
- * @return bool
+ * @return {boolean}
*/
this.hasSite = function ( siteId ) {
return this.getSite( siteId ) !== null;
@@ -99,7 +99,7 @@
* Returns a wikibase.Site object with details about a site by
the sites ID. If there is no site
* related to the given ID, null will be returned.
*
- * @param {int} siteId
+ * @param {string} siteId
* @return wikibase.Site|null
*/
this.getSite = function( siteId ) {
diff --git a/lib/resources/wikibase.utilities/wikibase.utilities.ui.js
b/lib/resources/wikibase.utilities/wikibase.utilities.ui.js
index 96f7cfe..cd585e6 100644
--- a/lib/resources/wikibase.utilities/wikibase.utilities.ui.js
+++ b/lib/resources/wikibase.utilities/wikibase.utilities.ui.js
@@ -16,7 +16,7 @@
* Whether page has rtl context.
* @type {boolean}
*/
- var IS_RTL = null;
+ var IS_RTL = false;
$( document ).ready( function() {
// have to wait for document to be loaded for this, otherwise
'rtl' might not yet be there!
--
To view, visit https://gerrit.wikimedia.org/r/166973
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6e9fc6dc8e0b63d47b3695ec75dcd68f065e06d
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Adrian Lang <adrian.l...@wikimedia.de>
Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
