jenkins-bot has submitted this change and it was merged. Change subject: Fixed Style/StringLiterals RuboCop offense ......................................................................
Fixed Style/StringLiterals RuboCop offense Bug: T113846 Change-Id: I9825d582b9e94662cbabe99651f6e242d31bd55d --- M .rubocop_todo.yml M Gemfile M tests/browser/features/support/env.rb M tests/browser/features/support/pages/editable_random_page.rb M tests/browser/features/support/pages/registration_page.rb 5 files changed, 16 insertions(+), 23 deletions(-) Approvals: Hashar: Looks good to me, approved jenkins-bot: Verified diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 77eeff2..e752c85 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -15,12 +15,6 @@ - 'tests/browser/features/support/pages/editable_random_page.rb' - 'tests/browser/features/support/pages/registration_page.rb' -# Offense count: 18 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/StringLiterals: - Enabled: false - # Offense count: 38 # Cop supports --auto-correct. Style/Tab: diff --git a/Gemfile b/Gemfile index ce6b54a..e9a988b 100755 --- a/Gemfile +++ b/Gemfile @@ -1,4 +1,4 @@ -source "https://rubygems.org" +source 'https://rubygems.org' -gem "mediawiki_selenium", "~> 0.4.2" -gem "rubocop", "~> 0.34.2", require: false +gem 'mediawiki_selenium', '~> 0.4.2' +gem 'rubocop', '~> 0.34.2', require: false diff --git a/tests/browser/features/support/env.rb b/tests/browser/features/support/env.rb index 8ac08ea..c768f2f 100644 --- a/tests/browser/features/support/env.rb +++ b/tests/browser/features/support/env.rb @@ -1 +1 @@ -require "mediawiki_selenium" +require 'mediawiki_selenium' diff --git a/tests/browser/features/support/pages/editable_random_page.rb b/tests/browser/features/support/pages/editable_random_page.rb index e37a707..4408a9e 100644 --- a/tests/browser/features/support/pages/editable_random_page.rb +++ b/tests/browser/features/support/pages/editable_random_page.rb @@ -1,9 +1,8 @@ class EditableRandomPage < RandomPage - h1(:title, id: "firstHeading") - div(:cta, id: "mw-gettingstarted-cta-editable-main-page") - a(:edit_this_page, id: "mw-gettingstarted-editable-main-edit-page") - a(:edit_suggested_page, id: "mw-gettingstarted-editable-main-fix-pages") - a(:no_thanks, class: "mw-gettingstarted-cta-leave-link") - - a(:create_account, css: "#pt-createaccount a") + h1(:title, id: 'firstHeading') + div(:cta, id: 'mw-gettingstarted-cta-editable-main-page') + a(:edit_this_page, id: 'mw-gettingstarted-editable-main-edit-page') + a(:edit_suggested_page, id: 'mw-gettingstarted-editable-main-fix-pages') + a(:no_thanks, class: 'mw-gettingstarted-cta-leave-link') + a(:create_account, css: '#pt-createaccount a') end diff --git a/tests/browser/features/support/pages/registration_page.rb b/tests/browser/features/support/pages/registration_page.rb index 0ab4db6..ef6dcd4 100644 --- a/tests/browser/features/support/pages/registration_page.rb +++ b/tests/browser/features/support/pages/registration_page.rb @@ -1,11 +1,11 @@ class RegistrationPage include PageObject - text_field(:username, id: "wpName2") - text_field(:password, id: "wpPassword2") - text_field(:password_confirmation, id: "wpRetype") - button(:register, id: "wpCreateaccount") - a(:return_to, css: "#mw-returnto a") + text_field(:username, id: 'wpName2') + text_field(:password, id: 'wpPassword2') + text_field(:password_confirmation, id: 'wpRetype') + button(:register, id: 'wpCreateaccount') + a(:return_to, css: '#mw-returnto a') def register_user(username) self.username = username @@ -13,7 +13,7 @@ self.password = password self.password_confirmation = password - if ENV.key?("MEDIAWIKI_CAPTCHA_BYPASS_PASSWORD") + if ENV.key?('MEDIAWIKI_CAPTCHA_BYPASS_PASSWORD') bypass_script = <<-END var $bypass = $( '<input>' ).attr( { type: 'hidden', -- To view, visit https://gerrit.wikimedia.org/r/241322 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9825d582b9e94662cbabe99651f6e242d31bd55d Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/GettingStarted Gerrit-Branch: master Gerrit-Owner: Zfilipin <zfili...@wikimedia.org> Gerrit-Reviewer: Dduvall <dduv...@wikimedia.org> Gerrit-Reviewer: Hashar <has...@free.fr> Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org> Gerrit-Reviewer: Phuedx <g...@samsmith.io> Gerrit-Reviewer: Swalling <steven.wall...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits