VolkerE has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348256 )
Change subject: MediaWiki theme: Clarify `@min-height-widget-default` usage
......................................................................
MediaWiki theme: Clarify `@min-height-widget-default` usage
Clarifying `@min-height-widget-default` usage and application.
Change-Id: I07e3fdaa6bb73922604cfcb5da23cf1ed22ebf56
---
M src/themes/mediawiki/common.less
M src/themes/mediawiki/elements.less
M src/themes/mediawiki/widgets.less
3 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/56/348256/1
diff --git a/src/themes/mediawiki/common.less b/src/themes/mediawiki/common.less
index fe1564e..095dd71 100644
--- a/src/themes/mediawiki/common.less
+++ b/src/themes/mediawiki/common.less
@@ -64,11 +64,11 @@
@min-width-button-default: 40 / @oo-ui-font-size-browser /
@oo-ui-font-size-default; // equals `3.125em`≈`40px` at base `font-size: 12.8px`
@min-width-button-combo-widget: 32 / @oo-ui-font-size-browser /
@oo-ui-font-size-default; // equals `2.5em`≈`32px`
@min-height-widget-default: @size-default;
-@min-height-button-default: 32 / @oo-ui-font-size-browser /
@oo-ui-font-size-default;
@min-height-toggleswitch: 26px; // equals `16px` @size-toggleswitch-grip-min +
4px*2 distance top/bottom + 1px*2 border top/bottom
@max-width-default: 50em;
@max-width-input: @max-width-default;
+// `@size-*` are used for both `width` & `height` properties
@size-default: 32 / @oo-ui-font-size-browser / @oo-ui-font-size-default;
@size-anchor: 9px;
@size-button-default: @size-default;
diff --git a/src/themes/mediawiki/elements.less
b/src/themes/mediawiki/elements.less
index 9a7002f..36dea51 100644
--- a/src/themes/mediawiki/elements.less
+++ b/src/themes/mediawiki/elements.less
@@ -208,7 +208,7 @@
&-framed {
> .oo-ui-buttonElement-button {
- min-height: @min-height-button-default;
+ min-height: @min-height-widget-default;
border-radius: @border-radius-default;
padding: @padding-default;
}
diff --git a/src/themes/mediawiki/widgets.less
b/src/themes/mediawiki/widgets.less
index af1c671..b8194c4 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -464,7 +464,7 @@
.oo-ui-buttonElement-button {
min-width: @min-width-button-combo-widget;
- min-height: @min-height-button-default;
+ min-height: @min-height-widget-default;
padding-left: 0;
> .oo-ui-indicatorElement-indicator {
@@ -531,7 +531,7 @@
.oo-ui-inline-spacing( 0.5em );
&-handle {
- min-height: @size-default; // Address label-less widgets
+ min-height: @min-height-widget-default; // Address label-less
widgets
border: @border-default;
border-radius: @border-radius-default;
padding: @padding-default;
--
To view, visit https://gerrit.wikimedia.org/r/348256
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I07e3fdaa6bb73922604cfcb5da23cf1ed22ebf56
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
