jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/348321 )
Change subject: reducers: Make LINK_CLICK finalize but not close ...................................................................... reducers: Make LINK_CLICK finalize but not close ... the interaction. Following on from Iccba3c4c, LINK_CLICK shouldn't be considered the end of an interaction because the link or preview can still be abandoned by the user. Unlike ABANDON_END and LINK_DWELL, therefore, LINK_CLICK musn't destroy the interaction but indicate that no more events should be enqueued for the interaction. More concretely, if the user has clicked the link or the preview, then a "dwelledButAbandoned" or "dismissed" event shouldn't be logged. Changes: * Distinguish between "finalizing" and "closing" an interaction, where the latter is the current behavior of ABANDON_END, LINK_DWELL, and LINK_CLICK, in the eventLogging reducer and associated tests. * If the interaction is finalized, then either the "dwelledButAbandoned" or "dismissed" events shouldn't be logged. Bug: T162924 Change-Id: I09d8776da992053f89a77508e29a7cde3cfeeac6 --- M resources/dist/index.js M resources/dist/index.js.map M src/reducers/eventLogging.js M tests/node-qunit/reducers/eventLogging.test.js 4 files changed, 101 insertions(+), 24 deletions(-) Approvals: jenkins-bot: Verified Jdlrobson: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/348321 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09d8776da992053f89a77508e29a7cde3cfeeac6 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Phuedx <samsm...@wikimedia.org> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
