jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/360323 )
Change subject: Don't keep forcing the camera to look back at the object
......................................................................
Don't keep forcing the camera to look back at the object
We only need to make sure the camera is facing out object
at first. If users decide to pan around, the camera shouldn't
look back.
Bug: T166696
Change-Id: I737f490b3a6e6589c62c304ebdc5a222b17bf6a2
---
M modules/mmv.3d.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
MarkTraceur: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/mmv.3d.js b/modules/mmv.3d.js
index 8526b25..df622fc 100644
--- a/modules/mmv.3d.js
+++ b/modules/mmv.3d.js
@@ -121,7 +121,6 @@
};
TD.render = function () {
- this.camera.lookAt( this.scene.position );
this.renderer.render( this.scene, this.camera );
};
@@ -166,6 +165,7 @@
threed.progressBar.hide();
threed.renderer.setSize( dimensions.width,
dimensions.height );
threed.$container.html( threed.renderer.domElement );
+ threed.camera.lookAt( threed.scene.position );
threed.render( threed.renderer, threed.scene,
threed.camera );
} ).progress( function ( progress ) {
threed.progressBar.animateTo( progress );
--
To view, visit https://gerrit.wikimedia.org/r/360323
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I737f490b3a6e6589c62c304ebdc5a222b17bf6a2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/3D
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
Gerrit-Reviewer: MarkTraceur <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
