Addshore has submitted this change and it was merged.
Change subject: Add update method to QueryStoreSetup
......................................................................
Add update method to QueryStoreSetup
Change-Id: I85d4ee7c65f25a8dcf4d8976d8992706245c6824
---
M src/QueryStoreSetup.php
M src/SQLStore/Setup.php
2 files changed, 26 insertions(+), 0 deletions(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/QueryStoreSetup.php b/src/QueryStoreSetup.php
index cb332e1..5bffe87 100644
--- a/src/QueryStoreSetup.php
+++ b/src/QueryStoreSetup.php
@@ -38,6 +38,17 @@
public function uninstall();
/**
+ * Updates the store schema to the latest version.
+ * This includes schema modifications, rebuilding of data where needed
+ * and doing initial population where needed.
+ *
+ * @since 0.1
+ *
+ * TODO: document throws
+ */
+ public function update();
+
+ /**
* Sets the MessageReporter to report messages with.
*
* @since 0.1
diff --git a/src/SQLStore/Setup.php b/src/SQLStore/Setup.php
index 1bec48b..76d6cd7 100644
--- a/src/SQLStore/Setup.php
+++ b/src/SQLStore/Setup.php
@@ -89,6 +89,8 @@
* @see QueryStoreSetup::install
*
* @since 0.1
+ *
+ * TODO: document throws
*/
public function install() {
$this->report( 'Starting install of ' .
$this->config->getStoreName() );
@@ -120,6 +122,8 @@
* @see QueryStoreSetup::uninstall
*
* @since 0.1
+ *
+ * TODO: document throws
*/
public function uninstall() {
$this->report( 'Starting uninstall of ' .
$this->config->getStoreName() );
@@ -148,4 +152,15 @@
return $success; // TODO: remove, or switch to using a try catch
}
+ /**
+ * @see QueryStoreSetup::update
+ *
+ * @since 0.1
+ *
+ * TODO: document throws
+ */
+ public function update() {
+ // TODO: implement
+ }
+
}
--
To view, visit https://gerrit.wikimedia.org/r/88977
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I85d4ee7c65f25a8dcf4d8976d8992706245c6824
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/WikibaseQueryEngine
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
