Ivzhh added a comment.
Hi everyone, Thank you for your encouragements and comments! I will follow up with all comments and update the code soon. @indygreg It is a great idea to test on Mozilla repo, actually I found several things interesting: 1. I found a bug in my code (shame on me): because I did not use byte literal, and I made a typo. This triggers problem in Mozilla unified repo 2. A regexp pattern in hgignore in Mozilla unified repo is not supported by rust's regex crate, a.k.a. "(?!)". I choose to ignore these unsupported patterns. 3. My version is slower in this repo: 70s (hg) and 90s (mine). CodeXL reveals that the mpatch::collect() function uses 63% of the running time. I think I need to optimize it somehow. I totally agree with @kevincox that I did not sort well on char/u8/str/String/Path/PathBuf. The first bug is caused by this. I need to improve them. Thank you everyone! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2057 To: Ivzhh, #hg-reviewers, kevincox Cc: glandium, krbullock, indygreg, durin42, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
