pulkit added a comment.
In https://phab.mercurial-scm.org/D4787#72712, @martinvonz wrote: > > Although this is called as a part of exchange.pull(), we don't want other > > extensions to wrap this pull call because it's not a normal pull and it's > > widening. > > I don't follow this. How does this prevent extensions from wrapping the pull? Do you mean that extensions that inspect the `source` parameter should not treat it like a normal pull? The `source` parameter also seems to be passed to hooks, btw (it probably makes sense to differentiate widening from pulling there too). Yes, I looked into the code where `source` parameter is used and it says the extension requires it. I think wrapping pull sounds to generic, I will improve the commit description. Thanks! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4787 To: pulkit, durin42, #hg-reviewers Cc: martinvonz, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
