On 15 April 2016 at 19:58, Chuck Atkins <chuck.atk...@kitware.com> wrote: > On Fri, Apr 15, 2016 at 2:07 PM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> >> On 15 April 2016 at 16:36, Chuck Atkins <chuck.atk...@kitware.com> wrote: >> > Instead of cascading support for various different implementations of >> > GLX, all three options are now specified through the --enable-glx >> > option: >> > >> Bth having the single switch looks a lot cleaner imho. Wondering if >> one shouldn't use --with-glx as this is the strange we handle non >> "yes/no" kind of things in mesa. >> >> I'm leaning that's a bad idea since people already use --enable-glx > > > I thought about that too but if I used --with, the it would make the most > sense to split the options with --enable-glx and > --wth-glx-implementation=[dri|xlib|gallium-xlib]. Since you can accomplish > all of this with a single --enable option I chose to stick with reduced > option complexity. > There shouldn't be any - I was thinking only about s/enable/with/. Then again keeping things as people are used would be better.
>> > AC_ARG_ENABLE([glx], >> > - [AS_HELP_STRING([--enable-glx], >> > - [enable GLX library @<:@default=enabled@:>@])], >> > + [AS_HELP_STRING([--enable-glx[=dri|xlib|gallium-xlib]], >> > + [enable the GLX library and choose an implementation >> > @<:@default=dri@:>@])], >> > [enable_glx="$enableval"], >> > [enable_glx=yes]) >> "enable_glx=dri" to reflect the help string. > > > Changed help string to [default=auto] to better reflect that some heuristic > is used to try to chose which one gets used. > Bth, I would rather keep the "default = dri" as "auto" feels a bit magical in this case, with the (although trivial if you know about it) heuristics in place. Will let others vote if we want --enable-glx to mean "autodetect between the tree providers" or the traditional "enable the dri based libGL" -Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev