From 3982b146747f319cd687afd3a13917b3af88fe0b Mon Sep 17 00:00:00 2001
From: Philipp Takacs <philipp@bureaucracy.de>
Date: Sat, 21 Mar 2026 14:48:24 +0100
Subject: [PATCH 6/6] better error messages

---
 table_api.c  | 8 ++++----
 table_ldap.c | 6 +++---
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/table_api.c b/table_api.c
index bf6b8fb..3b8d54a 100644
--- a/table_api.c
+++ b/table_api.c
@@ -125,7 +125,7 @@ fallback_update_handler(const char *id, const char *tname)
 	if (r == 1)
 		table_api_update_finish(id);
 	else
-		table_api_error(id, O_UPDATE, NULL);
+		table_api_error(id, O_UPDATE, "fallback_update_handler failed");
 }
 
 static void
@@ -141,7 +141,7 @@ fallback_check_handler(const char *id, const char *tname, int service, const cha
 	if (r == 0 || r == 1)
 		table_api_check_result(id, r == 1);
 	else
-		table_api_error(id, O_CHECK, NULL);
+		table_api_error(id, O_CHECK, "fallback_check_handler failed");
 }
 
 static void
@@ -161,7 +161,7 @@ fallback_lookup_handler(const char *id, const char *tname, int service, const ch
 	if (r == 1 || r == 0)
 		table_api_lookup_finish(id);
 	else
-		table_api_error(id, O_LOOKUP, NULL);
+		table_api_error(id, O_LOOKUP, "fallback_lookup_handler failed");
 }
 
 static void
@@ -183,7 +183,7 @@ fallback_fetch_handler(const char *id, const char *tname, int service)
 		table_api_fetch_result(id, NULL);
 		break;
 	default:
-		table_api_error(id, O_FETCH, NULL);
+		table_api_error(id, O_FETCH, "fallback_fetch_handler failed");
 	}
 }
 
diff --git a/table_ldap.c b/table_ldap.c
index b3348d4..612f329 100644
--- a/table_ldap.c
+++ b/table_ldap.c
@@ -299,7 +299,7 @@ ldap_handle_response(const char *ldapid, const struct aldap_message *m, struct r
 		}
 		break;
 	default:
-		table_api_error(req->id, req->o, NULL);
+		table_api_error(req->id, req->o, "respones for not implemented operation");
 		dict_pop(&requests, ldapid);
 		table_api_free_request(req);
 	}
@@ -509,7 +509,7 @@ ldap_open(void)
 
 	if (aldap) {
 		while (dict_poproot(&requests, (void **)&r)) {
-			table_api_error(r->id, r->o, NULL);
+			table_api_error(r->id, r->o, "ldap disconnected");
 			free(r);
 		}
 		oldfd = aldap->fd;
@@ -627,7 +627,7 @@ table_ldap_callback(struct request *req)
 	ctx.hostname = req->table;
 	ret = aldap_search(aldap, basedn, LDAP_SCOPE_SUBTREE, q->filter, &ctx, attrs, false, num, 0, NULL);
 	if (ret < 0) {
-		table_api_error(req->id, req->o, NULL);
+		table_api_error(req->id, req->o, "ldap error ... reconnecting");
 		ldap_open();
 		return;
 	}
-- 
2.52.0