From 7accf60971b84ee6f72cf9a816da02d6f1b52b59 Mon Sep 17 00:00:00 2001 From: Lauri Kasanen Date: Fri, 23 Mar 2012 17:24:35 +0200 Subject: [PATCH 3/3] mk_header: Move the bug check before the function Otherwise the mk_header_iov_add_entry function would operate on uninitialized data. Signed-off-by: Lauri Kasanen --- src/mk_header.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mk_header.c b/src/mk_header.c index fac8efb..8c6c4e3 100644 --- a/src/mk_header.c +++ b/src/mk_header.c @@ -248,11 +248,11 @@ int mk_header_send(int fd, struct client_session *cs, } } - mk_header_iov_add_entry(iov, response, mk_iov_none, MK_IOV_NOT_FREE_BUF); - /* Invalid status set */ mk_bug(i == status_response_len); + mk_header_iov_add_entry(iov, response, mk_iov_none, MK_IOV_NOT_FREE_BUF); + if (fd_status < 0) { mk_header_iov_free(iov); return -1; -- 1.7.2.1