----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107318/#review22279 -----------------------------------------------------------
Ship it! Once you fix up the patch, please feel free to commit. It's always good to have extra checks. - Vishesh Handa On Nov. 14, 2012, 4:19 a.m., Simeon Bird wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107318/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2012, 4:19 a.m.) > > > Review request for Nepomuk, Vishesh Handa and Sebastian Trueg. > > > Description > ------- > > Do not loop forever if there is an error executing the > query in createUri (for example, the connection to the > server died). Instead just return an empty url. > > Also check for such an error with createGraph in ResourceMerger::merge. > > This fixes a bug sort of introduced by > b54cbaa5e00c1191cd2e66399aeb86a04ba85ef1. > If something went wrong with virtuoso, xsession-errors would fill up the > available space, because each loop called executeQuery and added an error > message to the log. > > > Diffs > ----- > > services/storage/datamanagementmodel.cpp 0a68513 > services/storage/resourcemerger.cpp 41d6548 > > Diff: http://git.reviewboard.kde.org/r/107318/diff/ > > > Testing > ------- > > The usual > > > Thanks, > > Simeon Bird > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
