On Wed, 14 Aug 2019 05:31:54 +0000, John Fastabend wrote: > The ctx->sk_write_space pointer is only set when TLS tx mode is enabled. > When running without TX mode its a null pointer but we still set the > sk sk_write_space pointer on close(). > > Fix the close path to only overwrite sk->sk_write_space when the current > pointer is to the tls_write_space function indicating the tls module should > clean it up properly as well. > > Reported-by: Hillf Danton <[email protected]> > Cc: Ying Xue <[email protected]> > Cc: Andrey Konovalov <[email protected]> > Fixes: 57c722e932cfb ("net/tls: swap sk_write_space on close") > Signed-off-by: John Fastabend <[email protected]>
Reviewed-by: Jakub Kicinski <[email protected]> Thanks!
