I do this all the time (that is, I send SIGTERM after every workload I
run) in order to catch these issues. Is there some specific workload
that triggers this for you?
Daniel
On 02/01/2018 01:16 PM, Pradeep wrote:
Running some NFS workload and sending SIGTERM to ganesha (sudo killall
-TERM ganesha.nfsd) will reproduce it.
But you might hit a double-free problem before that - here is a patch
that fixes it.
https://review.gerrithub.io/#/c/398092/
Feel free to rework the patch above.
On Thu, Feb 1, 2018 at 6:59 AM, Daniel Gryniewicz <d...@redhat.com
<mailto:d...@redhat.com>> wrote:
I've been actually deliberately leaving that crash in. It indicates
a refcount leak (and is usually the only indicator of a refcount
leak, other than slowly growing memory over a long time).
Can you get me a reproducer for this? If so, I can track down the leak.
Daniel
On 02/01/2018 09:51 AM, Pradeep wrote:
Hello,
In graceful shutdown of ganesha (do_shutdown()), the way object
handles are released is first by calling unexport() and then
destroy_fsals(). One issue I'm seeing is unexport in MDCACHE
will not
release objects if refcnt is non-zero (which can happen if files are
open). When it comes to destroy_fsals() -> shutdown_handles() ->
mdcache_hdl_release() -> ...-> mdcache_lru_clean(), we don't have
op_ctx. So it will crashes in mdcache_lru_clean().
A simple fix would be to create op_ctx if it is NULL in
mdcache_hdl_release(). But I'm wondering if unexport is supposed to
free all handles in MDCACHE?
This is with 2.6-rc2 in case you want to look at code.
Thanks,
Pradeep
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
<mailto:Nfs-ganesha-devel@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
<https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
<mailto:Nfs-ganesha-devel@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
<https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
