Supriti pointed out that we are seeing an extra reference to FSAL_PSEUDO on
shutdown.
I've done some debug and code analysis, and I see that the extra reference
is coming as a result of this call to mdcache_export_init:
FSAL/FSAL_PSEUDO/export.c pseudofs_create_export 353 status =
mdcache_export_init(up_ops, &myself->export.up_ops);
I have verified that with an explicit FSAL_PSEUDO export, we now see TWO
extra references. Further, while we may need to do something back handed to
stack FSAL_MDCACHE on the automatic FSAL_PSEUDO export (if an export with
Pseudo="/" is not explicitly created), I wonder if this is doing an extra
stacking when an FSAL_PSEUSO export is explicitly created. No other FSAL
calls mdcache_export_init. And in fact, with the explicit FSAL_PSEUDO
export, I see these messages:
2018-02-07 16:27:09 [Admin]
/home/ffilz/ganesha/review/src/FSAL/fsal_destroyer.c:184 :destroy_fsals
:FSAL :EVENT :Shutting down handles for FSAL MDCACHE
2018-02-07 16:27:09 [Admin]
/home/ffilz/ganesha/review/src/FSAL/fsal_destroyer.c:59 :shutdown_handles
:FSAL :DEBUG :Extra file handles hanging around.
2018-02-07 16:27:09 [Admin]
/home/ffilz/ganesha/review/src/FSAL/fsal_destroyer.c:65 :shutdown_handles
:FSAL :DEBUG :Releasing handle
2018-02-07 16:27:09 [Admin]
/home/ffilz/ganesha/review/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_han
dle.c:1564 :mdcache_hdl_release :INODE :DEBUG :Releasing
obj_hdl=0x61b00001c7b8, entry=0x61b00001c780
2018-02-07 16:27:09 [Admin]
/home/ffilz/ganesha/review/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_han
dle.c:1566 :mdcache_hdl_release :INODE :DEBUG :Kill DIRECTORY entry
0x61b00001c780 obj_handle 0x61b00001c7b8
Which, except for the first, which always shows, do not show up without the
explicit FSAL_PSEUDO export.
I think we need a different way to manage the explicit stacking of mdcache
from build_default_root, and when we do, we don't need to do an fsal_get, we
already got a reference in this call:
support/exports.c build_default_root 1894 fsal_hdl = lookup_fsal("PSEUDO");
If we can get a fix for this in this week, cool, otherwise, it will go into
V2.7 and be backported (to both V2.6-stable and V2.5-stable, and maybe
V2.4-stable).
Frank
---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
