ctubbsii commented on a change in pull request #2309:
URL: https://github.com/apache/accumulo/pull/2309#discussion_r727467069
##########
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactableImpl.java
##########
@@ -602,9 +602,30 @@ public CompactableImpl(Tablet tablet, CompactionManager
manager,
Map<ExternalCompactionId,String> extCompactionsToRemove = new HashMap<>();
- var extSelInfo = initExternalSelection(extCompactions, tablet,
extCompactionsToRemove);
+ // Memoize the supplier so it only calls tablet.getCompactionID() once,
because the impl goes to
+ // zookeeper. Its a supplier because it may not be needed.
Review comment:
```suggestion
// zookeeper. It's a supplier because it may not be needed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
