kayx23 commented on PR #13215: URL: https://github.com/apache/apisix/pull/13215#issuecomment-4250419284
I found a few remaining doc mismatches in this PR: 1. `default_conn_delay` is still described incorrectly in the attribute table in both EN and ZH docs. It currently says it applies to concurrent requests exceeding `conn + burst`, but the implementation rejects requests at `conn + burst` and only delays requests after `conn` is exceeded. 2. `burst` and `rules.burst` are still described as applying "per second". That wording is misleading for `limit-conn`, since this plugin limits concurrent requests rather than a time-windowed request rate. 3. The Redis cluster docs are still internally inconsistent: the attribute table now says `redis_cluster_nodes` needs at least one address, but the Redis cluster example prose still says a minimum of two nodes is required for the plugin configuration. Implementation references: - `apisix/plugins/limit-conn/util.lua` - `apisix/utils/redis-schema.lua` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
