abdullah alamoudi has posted comments on this change.

Change subject: Add Active Partition Event Message
......................................................................


Patch Set 1:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1596/1/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/message/ActivePartitionMessage.java
File 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/message/ActivePartitionMessage.java:

PS1, Line 34: EVENT
> This name is confusing. The byte-sized member is called "event" and this is
Done


https://asterix-gerrit.ics.uci.edu/#/c/1596/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java:

PS1, Line 713: configureNodegroupForDataset
> s/dataverse/dataverseName/ to be consistent?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1596/2/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockManager.java
File 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockManager.java:

PS2, Line 83: tasetName, new 
> I think that there was a misunderstanding. I think that Mike's idea was to 
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1596
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b4629752e912614927b816d4ce3422ac89c5426
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to