BurningCN commented on a change in pull request #9381:
URL: https://github.com/apache/dubbo/pull/9381#discussion_r773673931



##########
File path: 
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultModuleDeployer.java
##########
@@ -92,14 +92,8 @@ public DefaultModuleDeployer(ModuleModel moduleModel) {
 
     @Override
     public void initialize() throws IllegalStateException {
-        if (initialized.get()) {
-            return;
-        }
         // Ensure that the initialization is completed when concurrent calls
-        synchronized (this) {
-            if (initialized.get()) {
-                return;
-            }
+        if (initialized.compareAndSet(false, true)) {
             loadConfigs();

Review comment:
       Adjust the type of initialized to volatile boolean




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to