[
https://issues.apache.org/jira/browse/OFBIZ-12329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609544#comment-17609544
]
Jacques Le Roux commented on OFBIZ-12329:
-----------------------------------------
Hi Charles,
After a quick review the patch sounds globally good to me. Despite a weird
patch format (eg: "Subject: [PATCH 7/9] Correction on condition filter", files
appearing more than once, etc.) that did not apply w/ other tools, I was able
to easily apply using git patch.
I tested and saw that it generates this locally in ecomseo when I turn to French
{code:}
<!-- Begin section
widgetcomponent://ecommerce/widget/CatalogScreens.xml#miniproductsummary id
c541b8ae-0379-49fd-872e-51873c8d8f32 -->
<!-- Begin Template
component://ecommerce/template/catalog/MiniProductSummary.ftl -->
<a href="/ecomseo/product/fr-tiny-gismo-GZ-1000.html" class="linktext">
Tiny Gizmo
</a>
{code}
when on demo (so no code change, just turned to French) I don't get this url but
{code}
<!-- Begin section
widgetcomponent://ecommerce/widget/CatalogScreens.xml#miniproductsummary id
11715a88-2162-4c85-8752-0647f5d4e190 -->
<!-- Begin Template
component://ecommerce/template/catalog/MiniProductSummary.ftl -->
<a href="/ecomseo/product/Tiny-Gizmo-GZ-1000.html" class="linktext">
Tiny Gizmo
</a>
{code}
So it seems to work for me. But before pushing, now my question: do you have
other test cases that I could use to validate all (or most) of the (not
neglectable) changes?
TIA
> Seo Improvements
> ----------------
>
> Key: OFBIZ-12329
> URL: https://issues.apache.org/jira/browse/OFBIZ-12329
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
> Affects Versions: Trunk, Upcoming Branch
> Reporter: Charles STELTZLEN
> Assignee: Jacques Le Roux
> Priority: Minor
>
> The system of alternatives url can not be used actually for translated url.
> The goal is to translation for alternative urls (content, product and
> category objects) and improve code (for example, the '/' character is now not
> mandatory for alternative url object info).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
