danwatford commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1146202300
##########
applications/product/groovyScripts/product/product/ProductServices.groovy:
##########
@@ -841,22 +867,24 @@ def checkOrderItemForProductGroupOrder() {
/**
* Cancle OrderItemGroupOrder
*/
-def cancleOrderItemGroupOrder() {
+Map cancleOrderItemGroupOrder() {
Review Comment:
I appreciate this seems a simple change and is an overall improvement, but
my concern is that all these little 'fixes' will add up to something that is
different to the original aim of translating the existing code to satisfy the
Codenarc rules and therefore adds to the cognitive load for someone to review
the changes.
My preference would be to leave existing behaviour as it is, and create some
other 'good housekeeping' tickets to be applied after this PR is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
