JacquesLeRoux commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1147549576
##########
applications/product/groovyScripts/product/promo/ProductPromoActionServices.groovy:
##########
@@ -173,18 +183,19 @@ def productGWP() {
Iterator<String> optionProductIdTempIter =
optionProductIds.iterator()
productId = optionProductIdTempIter.next()
optionProductIdTempIter.remove()
- product = from("Product").where("productId",
productId).cache().queryOne()
+ product = from('Product').where('productId',
productId).cache().queryOne()
}
if (!product) {
// no product found to add as GWP, just return
- return
+ return [*:result, actionResultInfo: parameters.actionResultInfo]
Review Comment:
Why is return different?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
