Comment deleted, I should have specified the method name. It's
updateLastAdminModified pushed to bottom
Le 24/03/2023 à 18:20, JacquesLeRoux (via GitHub) a écrit :
JacquesLeRoux commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1147868955
##########
applications/order/groovyScripts/shoppinglist/ShoppingListServices.groovy:
##########
@@ -131,39 +123,30 @@ def updateShoppingListItem() {
/**
* Remove a ShoppingListItem
- * @return
*/
-def removeShoppingListItem() {
- GenericValue shoppingList =
from("ShoppingList").where(parameters).queryOne()
- GenericValue shoppingListItem =
from("ShoppingListItem").where(parameters).queryOne()
+Map removeShoppingListItem() {
+ GenericValue shoppingList =
from('ShoppingList').where(parameters).queryOne()
+ GenericValue shoppingListItem =
from('ShoppingListItem').where(parameters).queryOne()
shoppingListItem.remove()
updateLastAdminModified(shoppingList, userLogin)
return success()
}
Review Comment:
Wait, I think I mixed with another file, checking....