gilPts commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1149424820
##########
applications/order/groovyScripts/shoppinglist/ShoppingListServices.groovy:
##########
@@ -320,13 +299,20 @@ def addSuggestionsToShoppingList() {
}
private List<GenericValue> linkProductToShoppingList(String productId, String
shoppingListId) {
- from("ProductAssoc")
- .where(productId: productId,
- productAssocTypeId: "PRODUCT_COMPLEMENT")
- .filterByDate()
- .queryList().each {
- run service: "addDistinctShoppingListItem", with: [productId :
it.productIdTo,
- shoppingListId:
shoppingListId,
- quantity :
(BigDecimal) 1]
+ from('ProductAssoc')
+ .where(productId: productId,
+ productAssocTypeId: 'PRODUCT_COMPLEMENT')
+ .filterByDate()
+ .queryList().each {
+ run service: 'addDistinctShoppingListItem', with:
[productId: it.productIdTo,
+
shoppingListId: shoppingListId,
+
quantity: (BigDecimal) 1]
+ }
+}
+
+private void updateLastAdminModified(GenericValue shoppingList, GenericValue
userLogin) {
Review Comment:
To fix the rule PublicMethodsBeforeNonPublicMethods rules : Enforce that
all public methods are above protected and private methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
