danwatford commented on PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1498969006
Hi @gilPts , I just tried a `./gradlew build` with your branch and received a build failure: ``` > Task :codenarcGroovyScripts FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':codenarcGroovyScripts'. > CodeNarc rule violations were found. See the report at: file:///C:/dev/floss/ofbiz/ofbiz-framework/build/reports/codenarc/groovyScripts.html ``` In the CodeNarc report I see there are 448 Priority 2 issues and 4396 Priority 3 issues listed. It seems unlikely that we will be able to address all of these quickly. Do you know if CodeNarc can be configured with a threshold of permitted Priority 2 and Priority 3 issues that would allow the build to proceed? This is approach we use with Checkstyle. If so, then over time we could gradually reduce the permitted number of issues until we hopefully reach zero, improving code 'hygiene' over time, but also getting CodeNarc integration in place as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
