wu-sheng commented on a change in pull request #5612:
URL: https://github.com/apache/skywalking/pull/5612#discussion_r500293710
##########
File path:
apm-sniffer/optional-plugins/customize-enhance-plugin/src/main/java/org/apache/skywalking/apm/plugin/customize/interceptor/BaseInterceptorMethods.java
##########
@@ -56,15 +56,14 @@ void beforeMethod(Method method, Object[] allArguments) {
}
}
if (tags != null && !tags.isEmpty()) {
- for (String key : tags.keySet()) {
- String expression = tags.get(key);
- spanTags.put(key,
CustomizeExpression.parseExpression(expression, context));
+ for (Map.Entry<String, String> expression:
tags.entrySet()) {
+ spanTags.put(expression.getKey(),
CustomizeExpression.parseExpression(expression.getValue(), context));
}
}
if (logs != null && !logs.isEmpty()) {
- for (String key : logs.keySet()) {
- String expression = logs.get(key);
- spanLogs.put(key,
CustomizeExpression.parseExpression(expression, context));
+ for (Map.Entry<String, String> entries : logs.entrySet()) {
+ String expression = logs.get(entries.getKey());
Review comment:
Seems so, just clicked the merge. Anyway, no real harm, if you want,
submit a pull request to fix again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
