On Fri, May 6, 2011 at 12:12 AM, Derek Homeier < de...@astro.physik.uni-goettingen.de> wrote:
> > On 5 May 2011, at 22:53, Derek Homeier wrote: > > >> > >> However, the problem that ndmin is supposed to address is not fixed > >> by the current implementation for the rc. Essentially, a single- > >> row, multi-column file with ndmin=2 comes out as a Nx1 array which > >> is the same result for a multi-row, single-column file. My feeling > >> is that if we let the current implementation stand as is, and > >> developers use it in their code, then fixing it in a later release > >> would introduce more problems (maybe the devels would transpose the > >> result themselves or something). Better to fix it now in rc with > >> the two lines of code (and the correction to the tests), then to > >> introduce a buggy feature that will be hard to fix in future > >> releases, IMHO. > >> > >> Looks okay, and I agree that it's better to fix it now. The timing > >> is a bit unfortunate though, just after RC2. I'll have closer look > >> tomorrow and if it can go in, probably tag RC3. > >> > >> If in the meantime a few more people could test this, that would be > >> helpful. > >> > >> Ralf > > > > I agree, wish I had time to push this before rc2. I could add the > > explanatory comments > > mentioned above and switch to use the atleast_[12]d() solution, test > > that and push it > > in a couple of minutes, or should I better leave it as is now for > > testing? > > Quick follow-up: I just applied the above changes, added some tests to > cover Ben's test cases and tested this with 1.6.0rc2 on OS X 10.5 > i386+ppc > + 10.6 x86_64 (Python2.7+3.2). So I'd be ready to push it to my repo > and do > my (first) pull request... > Go ahead, I'll have a look at it tonight. Thanks for testing on several Pythons, that definitely helps. Ralf
_______________________________________________ NumPy-Discussion mailing list NumPy-Discussion@scipy.org http://mail.scipy.org/mailman/listinfo/numpy-discussion
