Author: jacopoc Date: Wed Oct 18 09:21:18 2006 New Revision: 465290 URL: http://svn.apache.org/viewvc?view=rev&rev=465290 Log: Small change that hopefully should fix the bug reported by Ray Barlow in OFBIZ-380: reservations are lost when an order item is cancelled.
Modified: incubator/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java Modified: incubator/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java?view=diff&rev=465290&r1=465289&r2=465290 ============================================================================== --- incubator/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java (original) +++ incubator/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java Wed Oct 18 09:21:18 2006 @@ -3154,7 +3154,7 @@ if (valueObj.get("carrierRoleTypeId") == null) { valueObj.set("carrierRoleTypeId", "CARRIER"); } - if (valueObj.get("supplierPartyId") != null) { + if (!UtilValidate.isEmpty(valueObj.get("supplierPartyId"))) { dropShipGroupIds.add(valueObj.getString("shipGroupSeqId")); } } else if ("OrderAdjustment".equals(valueObj.getEntityName())) {