On Mar 22, 2012 8:50 AM, "Meinert Jordan" <meinertjor...@openlp.org> wrote: > Your list of reserved filename characters is incomplete. > For example the squared brackets are forbidden on FAT32 ( http://en.wikipedia.org/wiki/Filename). > The old list contains all reserved characters except of control characters.
Thanks. I've overlooked that. I'll rectify that and try to get it submitted this evening. On Mar 22, 2012 9:37 AM, "Jonathan Corwin" <j...@corwin.co.uk> wrote: > > You've created the constant CONTROL_CHARS but you've chosen not to use it on line 36. > Perhaps you could use the constant and then just rstrip() to remove the rest instead of the '| +$'? Can I do something like from openlp.core.utils import CONTROL_CHARS? I just thought the '| +$' was a bit more elegant than the other solution. And anyways, I wanted to use my new found regular expression "skills" ;-) Phill -- https://code.launchpad.net/~phill-ridout/openlp/bug952533/+merge/98788 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
