Review: Needs Fixing Please do not do this: 55 +from appscript import * rather do import appscript
59 + 60 +log = logging.getLogger(__name__) 61 + 62 +class KeynoteController(PresentationController) Before and after the "log = " should be two blank lines 106 + if self.process and len(self.process.slideshows()) > 0: When dealing with lists do "if not my_list" instead of "if len(my_list) > 0" 387 + text = '' 391 + text += shape.TextFrame.TextRange.Text + '\n' If not explicit wanted do not use strings; use unicode strings: u'' -- https://code.launchpad.net/~marmyshev/openlp/presentation/+merge/154795 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
