Summary: amfd: allow increase of saAmfSGNumPrefActiveSUs for N+M SG while UNLOCKED Review request for Trac Ticket(s): 871 Peer Reviewer(s): Hans F Pull request to: Hans F Affected branch(es): default Development branch:
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- I didn't want to handle the deletion in this bug. There is already code in ccb_completed_modify_hdlr that looks at DELETION and just continues the loop without doing anything. So, no deletion is being handled there at all. Are there other attributes we want to treat this way? Handling the deletion of saAmfSGNumPrefActiveSUs in ccb_completed_modify_hdlr cleanly will require some reorg of ccb_completed_modify_hdlr which I think is outside the scope of this bug. changeset bae2d2e9601f2e1f09e4ac8d60d4e118b448cd20 Author: Alex Jones <[email protected]> Date: Mon, 19 May 2014 17:40:58 -0400 amfd: allow increase of saAmfSGNumPrefActiveSUs for N+M SG while UNLOCKED [#871] ccb_completed_modify_hdlr: Attribute 'saAmfSGNumPrefActiveSUs' cannot be modified when SG is unlocked OpenSAF disallows changing saAmfSGNumPrefActiveSUs while the SG is UNLOCKED. This prevents in-service capacity upgrade for N+M models, which is not desirable. This change allows saAmfSGNumPrefActiveSUs to be increased for N+M models, as long as there are instantiated spare SUs equal to the amount of the increase. These instantiated spare SUs will then be assigned ACTIVE, and their corresponding CSIs will be assigned to the STANDBY. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/sg.cc | 42 ++++++++++++++++++++++++++++++++++++++++ 1 files changed, 42 insertions(+), 0 deletions(-) Testing Commands: ----------------- 1) create an N+M SG, with at least 3 SUs, and have saAmfSGNumPrefActiveSUs be 1 2) make sure the SG is UNLOCKED 3) immcfg -a saAmfSGNumPrefActiveSUs=2 safSg=XXX,... Testing, Expected Results: -------------------------- The change should be allowed, and the instantiated spare SU is now active. Conditions of Submission: ------------------------- Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
