Summary: imm: In immnd_evt_proc_ccb_compl_rsp skip to end if PBE-OI is detached [#1096] Review request for Trac Ticket(s): 1096 Peer Reviewer(s): Neel Pull request to: Affected branch(es): 4.3; 4.4; 4.5; default(4.6) Development branch:
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset df26c266f9c0f713bf1313c5202dfb279ff4fa59 Author: Anders Bjornerstedt <[email protected]> Date: Mon, 22 Sep 2014 16:50:07 +0200 imm: In immnd_evt_proc_ccb_compl_rsp skip to end if PBE-OI is detached [#1096] The case is where a CCB has passed validation by all involved OIs. Normally the next step, if PBE is enabled, is to send the completed callbac to the PBE-OI. The PBE actually commits the ccb/sqlite-transaction in the completed callback. But in this case, the PBE has detached after the ccb has been built up, but before imm-ram can send the completed-callback to the PBE. In this case it is in princple ok for imm-ram to abort the CCB, since the PBE has not received any completed callback and can not have comitted this ccb to disk. But instead of complicating the ccb-state machine in ImmModel, just to optimize an error case, the solution has been to just drop the send of completed to PBE and let this error case merge with the case when the message was successfully sent to the PBE yet the PBE restarted before replying. The problem was that continued execution in this branch implied use of the client node, which was missing. The solution is to goto the end of the function. Complete diffstat: ------------------ osaf/services/saf/immsv/immnd/immnd_evt.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) Testing Commands: ----------------- Error reported by coverity. Testing, Expected Results: -------------------------- Conditions of Submission: ------------------------- Ack from Neel Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
