Hi Ramesh, I used your system to publish , so accidentally your name is getting displayed as publisher , please ignore.
Provide your review comment by reviewing it. -AVM On 5/14/2015 2:43 PM, [email protected] wrote: > Summary:cpsv: enhance cpnd to shm read/write size to SaOffsetT(SaUint64T) > [#1372] > Review request for Trac Ticket(s): #1372 > Peer Reviewer(s): Ramesh > Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> > Affected branch(es): default 4.6 > Development branch: default > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services n > OpenSAF services y > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > changeset b572018cf7832c5b689b67c107ea25daaa98dc92 > Author: Ramesh <[email protected]> > Date: Thu, 14 May 2015 14:39:28 +0530 > > cpsv: enhance cpnd to shm read/write size to SaOffsetT(SaUint64T) > [#1372] > Currently because of limitation in Leap ncs_os_posix_shm() function > > the maxSectionSize defined in CKPT is of SaUint32T type and the offset > which > is been derived from +maxSectionSize , > > Now the Ticket #1271 is enhanced leap functionality to accommodate > SaUint64T > , cpsv will align to uint64_t type to read/write large offset value. > > Changed ncs_os_posix_shm() interfaceing function of cpnd to support > SaOffsetT (SaUint64T) size. > > > Complete diffstat: > ------------------ > osaf/libs/common/cpsv/include/cpnd.h | 1 + > osaf/libs/common/cpsv/include/cpnd_cb.h | 4 ++-- > osaf/libs/common/cpsv/include/cpnd_init.h | 4 ++-- > osaf/libs/core/include/ncs_osprm.h | 6 +++--- > osaf/services/saf/cpsv/cpnd/cpnd_proc.c | 17 ++++++++++++++--- > osaf/services/saf/cpsv/cpnd/cpnd_res.c | 69 > +++++++++++++++++++++++++++++++++++++++++++++++---------------------- > 6 files changed, 69 insertions(+), 32 deletions(-) > > > Testing Commands: > ----------------- > creating/writing/reading/updating/deleting collocated checkpoint with > checkpoint section 5000 and each section size of 2MB > creating/writing/reading/updating/deleting no-collocated checkpoint > with checkpoint section 5000 and each section size of 2MB > restating CPND when collocated/no-collocated after creating checkpoint > with checkpoint section 5000 and each section size of 2MB > > Testing, Expected Results: > -------------------------- > > > Conditions of Submission: > ------------------------- > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > > ------------------------------------------------------------------------------ > One dashboard for servers and applications across Physical-Virtual-Cloud > Widest out-of-the-box monitoring support with 50+ applications > Performance metrics, stats and reports that give you Actionable Insights > Deep dive visibility with transaction tracing using APM Insight. > http://ad.doubleclick.net/ddm/clk/290420510;117567292;y > _______________________________________________ > Opensaf-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/opensaf-devel ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
